Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for contextual help layout #6933

Merged
merged 1 commit into from Aug 2, 2019
Merged

fix for contextual help layout #6933

merged 1 commit into from Aug 2, 2019

Conversation

@rvalieris
Copy link
Contributor

@rvalieris rvalieris commented Aug 2, 2019

References

fix for #6928

rationale is on the issue.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Aug 2, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 2, 2019

Thanks for finding the issue, filing the issue, tracking down the fix, and submitting a PR!

@jasongrout jasongrout merged commit 52a3305 into jupyterlab:master Aug 2, 2019
9 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 2, 2019

CC @afshin as well

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 2, 2019

Ah, I figured out why display:flex was there. The default content depends on it to center the content vertically:

.jp-Inspector-default-content {
align-items: center;
justify-content: center;
font-size: xx-large;
font-style: italic;
color: darkgray;
}

I think it's probably even better to not center vertically? Then people looking at the top of the tab for content don't miss the function. But we probably should go ahead and delete the relevant items in the default-content css (or just add back in the display:flex there)

@rvalieris rvalieris deleted the fix branch Aug 2, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 2, 2019

Could you put in one more PR to add display:flex back into .jp-Inspector-default-content? I should have caught this before merging this PR. That will restore the current behavior, so we don't need to have a discussion about how to change the current behavior of the default content.

@rvalieris
Copy link
Contributor Author

@rvalieris rvalieris commented Aug 2, 2019

opened #6935 !

@rvalieris
Copy link
Contributor Author

@rvalieris rvalieris commented Aug 2, 2019

oh wait my bad I confused the classes, I will change the commit on the PR there

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 2, 2019

Thanks!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 9, 2019

@meeseeksdev backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Aug 9, 2019
blink1073 added a commit that referenced this issue Aug 9, 2019
…3-on-1.0.x

Backport PR #6933 on branch 1.0.x (fix for contextual help layout)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants