Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the search debounce from 100ms to 500ms #7034

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@krassowski
Copy link
Member

@krassowski krassowski commented Aug 16, 2019

References

Solves #7007

User-facing changes

The search will not start up until 500ms after the last character was typed, which was previously 100ms. This follows the discussion in #7007 and is motivated by the slowness of search (and interface slowness) when lots of characters are matched. This value could be decreased to more balanced 250ms in the future once we have a way to speed up rendering of CodeMirror editors.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Aug 16, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 16, 2019

Thank you!

@blink1073 - let's get this into 1.0.6 as well.

@jasongrout jasongrout added this to the 1.1 milestone Aug 16, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 16, 2019

@meeseeksdev backport to 1.0.x

@meeseeksdev
Copy link

@meeseeksdev meeseeksdev bot commented Aug 16, 2019

Something went wrong ... Please have a look at my logs.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 16, 2019

I think it has to be merged before you can backport.

@blink1073 blink1073 merged commit d927bd4 into jupyterlab:master Aug 16, 2019
9 checks passed
@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 16, 2019

@meeseeksdev backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Aug 16, 2019
blink1073 added a commit that referenced this issue Aug 16, 2019
…4-on-1.0.x

Backport PR #7034 on branch 1.0.x (Increase the search debounce from 100ms to 500ms)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants