Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the url resolver to its full capabilities for vega. #7098

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 27, 2019

References

Fixes #7047

Extends #7022

Code changes

The vega renderers were using the resolver a little bit, but needed to use it to its full extent.

User-facing changes

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Aug 27, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Aug 28, 2019

CC @blink1073 or anyone else - I'd like to get this bugfix in 1.1.

Copy link
Member

@blink1073 blink1073 left a comment

LGTM, thanks!

@blink1073 blink1073 merged commit 105f7af into jupyterlab:master Aug 28, 2019
7 of 9 checks passed
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Aug 28, 2019

@meeseeksdev backport to 1.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Aug 28, 2019
jasongrout added a commit that referenced this issue Aug 28, 2019
…8-on-1.0.x

Backport PR #7098 on branch 1.0.x (Use the url resolver to its full capabilities for vega.)
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants