Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file browser location in tree view. #7155

Merged
merged 2 commits into from Oct 10, 2019
Merged

Fix file browser location in tree view. #7155

merged 2 commits into from Oct 10, 2019

Conversation

dmarth
Copy link

@dmarth dmarth commented Sep 5, 2019

References

#6874

Code changes

The file browser now opens the /tree path first, then optionally the file-browser-path is shown. Additionally, the query parameter is deleted from the URL.

User-facing changes

The query parameter is now removed from the URL.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Sep 5, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout requested a review from afshin Sep 9, 2019
@dmarth
Copy link
Author

@dmarth dmarth commented Sep 23, 2019

@afshin any remarks on that?

@afshin afshin changed the title fixed file browser location in tree view and removed parameter from URL Fix file browser location in tree view. Sep 26, 2019
afshin
afshin approved these changes Sep 26, 2019
Copy link
Member

@afshin afshin left a comment

I am 👍 on this. I submitted a small pull request https://github.com/dmarth/jupyterlab/pull/1 against your branch to add some clarifying comments.

@jasongrout jasongrout merged commit 6d0882f into jupyterlab:master Oct 10, 2019
7 of 9 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Oct 10, 2019

@meeseeksdev backport to 1.x

@jasongrout jasongrout added this to the 2.0 milestone Oct 10, 2019
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 10, 2019
jasongrout added a commit that referenced this issue Oct 10, 2019
…5-on-1.x

Backport PR #7155 on branch 1.x (Fix file browser location in tree view.)
@dmarth dmarth deleted the fix-filebrowser-location-parameter branch Oct 11, 2019
@lock lock bot added the status:resolved-locked label Nov 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants