Fix UI problems when some of the package versions mismatch #7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
telamonian
changed the title
|
This looks reasonable to me, and running it in dev mode works too. @telamonian - do you think it's ready to merge? |
jasongrout
approved these changes
Sep 10, 2019
|
@jasongrout Yes. I have thoroughly tested it, both in dev mode and against a broken |
|
Thanks! |
|
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Sep 10, 2019
… versions mismatch
jasongrout
added a commit
that referenced
this pull request
Sep 10, 2019
…2-on-1.1.x Backport PR #7182 on branch 1.1.x (Fix UI problems when some of the package versions mismatch)
|
Fixes #7158 as well |
This was referenced Sep 10, 2019
This was referenced Sep 12, 2019
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
fixes #7181
and a whole bunch of other recent issues
Code changes
The latest version of eg
ui-componentsrelies on recent changes made across the codebase. There's currently an issue where a1.0.xinstallation of Jlab (up to1.0.7) will pull in the newest version of a package under certain conditions (eg install an extension and then rebuild). This in turn was causing various problems with the appearance of Jlab. This PR fixes three such appearance bugs, listed in order of descending severity:ui-componentsrelies on changes made to the.svgloader configuration inwebpack.config.js. This PR adds a shim that allows the new icon stuff inui-componentsto work properly with.svgfiles loaded the old way.apputilsrelies on changes made to the schema inthemes.jsonin the latest version ofapputils-extension. The PR adds an explicit check for those changes, and graceful handling if they aren't there.User-facing changes
No more appearance glitches for
v1.0.0-1.0.7Backwards-incompatible changes