Use temp directories and error handling better in release process and release testing. #7243
Conversation
… release testing.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
| cd $WORK_DIR | ||
|
|
||
| conda deactivate |
There was a problem hiding this comment.
Why don't we need this here? To me it looks like we should instead be adding this to release_test.sh as well to make sure we start from a fresh env.
There was a problem hiding this comment.
conda activate appropriately nests environments these days.
There was a problem hiding this comment.
i.e.,
conda activate A
conda activate B
puts you in environment B, and conda deactivate puts you back in A.
I'm always running these scripts from a fresh terminal anyway. If you're not, there's no guarantee that conda deactivate actually deactivates all environments.
There was a problem hiding this comment.
I meant the remove part. I needed to call deactivate first because it wouldn't remove the active env. But point taken about using a fresh terminal.
There was a problem hiding this comment.
conda now automatically removes an environment if you create one with the same name as an existing one: conda/conda#7133
|
@meeseeksdev backport to 1.x |
…better in release process and release testing.
…3-on-1.x Backport PR #7243 on branch 1.x (Use temp directories and error handling better in release process and release testing.)
lock
bot
added
the
status:resolved-locked
References
Code changes
User-facing changes
Backwards-incompatible changes
None