removed svg styling from old icon behavior fallback #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
This PR is ready to go. @mbektasbbg Can you please test this out and see if solves your problem? |
|
thanks @telamonian, I just tested your fix and it works great! |
|
@meeseeksdev backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Sep 27, 2019
jasongrout
added a commit
that referenced
this pull request
Oct 2, 2019
…6-on-1.x Backport PR #7266 on branch 1.x (removed svg styling from old icon behavior fallback)
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
fixes #7265
Code changes
Removes SVG-specific styling from icons when icon handling falls back to the old "icons as CSS background images" behavior.
Also fixed SVG styling for toolbar icon labels.
User-facing changes
Toolbar icon labels now display correctly.
Backwards-incompatible changes
None