Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added split-cell multicursor #7417

Merged
merged 1 commit into from Oct 26, 2019
Merged

Added split-cell multicursor #7417

merged 1 commit into from Oct 26, 2019

Conversation

@benthayer
Copy link
Member

@benthayer benthayer commented Oct 26, 2019

References

fixes #7207
Same as jupyter/notebook#4824

Code changes

Prior code only split using the active cursor while this takes into account both cursors and selections. Essentially, it uses cursors as delimiters and ensures that text in selections ends up in the same cell.

Similar to before, the last cell created contains the output of the split cell and gets selected after the operation is complete. The action is also undoable, just like before.

User-facing changes

The user can now use multicursor to split the cell in multiple locations.

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Oct 26, 2019

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@benthayer
Copy link
Member Author

@benthayer benthayer commented Oct 26, 2019

Sorry for the force push, I accidentally added a .rej file that was automatically created

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 26, 2019

Thanks again, works as advertised!

@blink1073 blink1073 added this to the 1.2 milestone Oct 26, 2019
@blink1073 blink1073 merged commit f0f1ac2 into jupyterlab:master Oct 26, 2019
7 of 9 checks passed
@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 26, 2019

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Oct 26, 2019
blink1073 added a commit that referenced this issue Oct 26, 2019
…7-on-1.x

Backport PR #7417 on branch 1.x (Added split-cell multicursor)
@benthayer
Copy link
Member Author

@benthayer benthayer commented Oct 26, 2019

Happy to help!

@benthayer benthayer deleted the split-cell branch Oct 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2019
@jasongrout jasongrout removed this from the 1.2 milestone Feb 24, 2020
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants