Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test jupyter lab without nodeJS #7465

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Conversation

fcollonval
Copy link
Member

References

Fixes #7462

Code changes

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval force-pushed the fix-7462 branch 3 times, most recently from f544554 to a67b82c Compare November 3, 2019 11:45
@fcollonval
Copy link
Member Author

@jasongrout and @blink1073 Here is a proposal to test installing and running JupyterLab without NodeJS.

I added a group nonode in the Linux matrix. For that group, the JupyterLab wheel is build in ci_install.sh. Then node is removed. And in ci_script.sh, JupyterLab is installed from that wheel and executed. Should we have additional actions?

Note: jupyterlab.browser_check is unfortunately not possible as node is removed.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is about as good as we can get without a browser check, other than checking for error logs that don't actually stop the application. Thanks!

@fcollonval fcollonval force-pushed the fix-7462 branch 2 times, most recently from 732139c to a6b7f8a Compare November 14, 2019 20:22
@blink1073
Copy link
Member

Perfect, thank you!

@blink1073 blink1073 added this to the 2.0 milestone Nov 15, 2019
@blink1073 blink1073 merged commit 3b877b2 into jupyterlab:master Nov 15, 2019
@fcollonval fcollonval deleted the fix-7462 branch November 16, 2019 08:43
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test to simulate JupyterLab usage without NodeJS
2 participants