Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Labeler Workflow #7735

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix Labeler Workflow #7735

merged 1 commit into from
Jan 3, 2020

Conversation

declanvk
Copy link
Contributor

@declanvk declanvk commented Jan 3, 2020

This is a draft until a successful workflow is observed. Also, 5 minutes between runs might be too short.

Since the workflow only runs on the master branch, it can't test changes in a PR (I think). I'll keep an eye on the Actions to see if further issues arise after this if merged.

References

Issue with discussion: #7729. Previous PRs: #7734 #7730.

Code changes

Labeler workflow had a duplicated name field for the top level.

User-facing changes

None

Backwards-incompatible changes

None

**Description**
Labeler workflow had a duplicated name field for the top level.

**Motivation**
Bug fix, the labeler workflow should work after this PR is complete.

**Testing Done**
Observer a successful run of the workflow before merging the PR.
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@declanvk declanvk changed the title Fix Labeler Workflow [DRAFT] Fix Labeler Workflow Jan 3, 2020
@declanvk declanvk changed the title [DRAFT] Fix Labeler Workflow Fix Labeler Workflow Jan 3, 2020
@blink1073
Copy link
Member

This won't get run until it is merged, right?

@blink1073 blink1073 merged commit c5e9574 into jupyterlab:master Jan 3, 2020
@declanvk declanvk deleted the fix-workflow branch January 3, 2020 23:11
@blink1073
Copy link
Member

Hmm, it ran successfully but didn't label anything.

@declanvk
Copy link
Contributor Author

declanvk commented Jan 3, 2020

Take a look here: #5953. It does the pull requests in order of open and sorted by recently updated: https://github.com/jupyterlab/jupyterlab/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc.

But it seems to stop about halfway down the page, possibly it hit a rate limit?

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants