Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Clearer Read Only Status #7980

Closed
mlucool opened this issue Mar 3, 2020 · 9 comments · Fixed by #14600
Closed

UX: Clearer Read Only Status #7980

mlucool opened this issue Mar 3, 2020 · 9 comments · Fixed by #14600

Comments

@mlucool
Copy link
Contributor

mlucool commented Mar 3, 2020

Description

Read only notebooks in lab do not have any indication that save is failing nor that they are read only.

In Notebook there are both indications:
image

The left tag comes when you try and save and the right icon is always visible on read only notebooks.

Proposal:

We add these back in a similar spot (next to the kernel name).

I do not have a good suggestion on what to do for non-notebooks files as there is no real space in the editor. The bottom info bar (where line/col numbers are) seems like the wrong place.

Context

  • JupyterLab version: 1.2.3
@jasongrout
Copy link
Contributor

I thought the save toolbar button was grayed out, right? It's not as visible as the above indications, but it is something.

@mlucool
Copy link
Contributor Author

mlucool commented Mar 3, 2020

Yes, sorry - the save icon is grayed out. Can we move it back to the no save icon? Grayed out is less in your face so I missed it!

Similarly, I still think we should add feedback when a user hits ctrl-s and nothing happens.

@jasongrout
Copy link
Contributor

I do think it would be great to have clearer readonly status, like you say.

@jasongrout jasongrout added this to the Future milestone Mar 3, 2020
@isabela-pf
Copy link
Contributor

I did some exploration on how to indicate a notebook's status like this a little while back, so here are some mockups for potential solutions.

  1. First there's what was proposed above: follow what Notebook does. I updated it to match our current UI, but it's essentially the same. Personally, I find this as easy to miss as the greyed out save button.

Notebook 2

  1. Another more subtle option is to change the icon in the tab. I don't think this would be sufficient on it's own, but it might be a nice detail to combine with another approach so users have more chances to be reminded of the read-only status. Right now it is the material icon "visibility," but I'm not set on this being the best choice.

Icon 1

  1. I also explored this persistent UI option in the notebook panel. It is harder to miss, but could be too obtrusive and does push the notebook down on the page a little bit. I'm also not aware of a precedent for this kind UI in JupyterLab now, which could be an issue. Still, if missing the notebook status is a common issue then something like this might help.

Top Bar 1

@mlucool
Copy link
Contributor Author

mlucool commented Apr 23, 2020

Thanks @isabela-pf. FWIW, I like 3 followed by 1. I don't think 2 is clear enough.

@telamonian
Copy link
Member

I'd advocate for having 1., 2. (but only with the right icon), and 3., and having 3. be able to dismissed by clicking anywhere on the banner.

If we are going to combine 1. and 3., then I think another variant of 1. that would be worth exploring would be to echo notebook classic: put a wide "read only" badge to left of our "trusted" icon, which in our case happens to be below the notebook on the status bar. That way, once the user acknowledges/dismisses the initial loud banner at the top of the notebook, they can then continue to use the notebook without much extra visual burden.

@isabela-pf
Copy link
Contributor

It sounds like 1 might be the better option because it is familiar to Notebook users and seems like it would not require the same unique treatment to implement that 3 likely would. I do think 1 and 2 could be combined effectively.

I also missed the earlier mention that we might want feedback reminding a user that the notebook cannot be saved if the try and ctrl+s it. That sounds like a good idea to me, but I think we'd have to be careful to make this feedback minimally disruptive. I don't think a dialog is appropriate and I'm not aware of another toast-like or similar feedback system already a part of JupyterLab.

@isabela-pf
Copy link
Contributor

I'm following up on my previous comment with another mockup. The first combines 1 and 2 to provide an approach that might be familiar from Notebook while having an (albeit small) icon indication in the tab as added support.

IconClassicCrop

With toast notifications moving forward in #689, I think this could be a good opportunity to remind users a notebook is read-only if they try to save. I could see this being potentially annoying if it repeats, but since toasts last 10 seconds at most I think it could work if it seems like there should be an additional reminder of read-only status.

IconClassic

@GabrielaVives
Copy link

I have been reading the discussion above and am wondering if there been an agreement on the best design for this feature?

I agree with the idea of having a toast notification appear if the user tries to save the notebook, otherwise there is a risk of users not understanding and thinking that something is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants