Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to improved readonly UI: add Toast notifcations #12827

Open
telamonian opened this issue Jul 20, 2022 · 5 comments
Open

Followup to improved readonly UI: add Toast notifcations #12827

telamonian opened this issue Jul 20, 2022 · 5 comments

Comments

@telamonian
Copy link
Member

I'm following up on my previous comment with another mockup. The first combines 1 and 2 to provide an approach that might be familiar from Notebook while having an (albeit small) icon indication in the tab as added support.

IconClassicCrop

With toast notifications moving forward in #689, I think this could be a good opportunity to remind users a notebook is read-only if they try to save. I could see this being potentially annoying if it repeats, but since toasts last 10 seconds at most I think it could work if it seems like there should be an additional reminder of read-only status.

IconClassic

Originally posted by @isabela-pf in #7980 (comment)

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Jul 20, 2022
@telamonian
Copy link
Member Author

telamonian commented Jul 20, 2022

I'm splitting @isabela-pf's Toast-on-attempted-save UI proposal (described above) out from #7980 into a fresh issue here. The easy way to do this would be to incorporate an already existing quality Snackbar/Toast component, such as these fine examples:

  • material-ui Snackbar
    • looks good
    • super flexible
    • con: have to bring in the large mui package, though in theory tree-shaking should mitigate this
  • light-toast
    • small (5 kb as per bundlephobia)
    • con: smallish user base

@vidartf
Copy link
Member

vidartf commented Jul 20, 2022

I think this is the oldest issue tracking toasts: #689

@vidartf
Copy link
Member

vidartf commented Jul 20, 2022

Someone also mentioned this: https://github.com/jupyterlab-contrib/jupyterlab_toastify

@fcollonval
Copy link
Member

fcollonval commented Jul 21, 2022

Copying here the discussion summary from the weekly meeting:

@fcollonval
Copy link
Member

fcollonval commented Jul 21, 2022

Additional comments:

  • FAST Design does not provide a default notification UI. And I support Max that implementing our own is not straighforward.
  • jupyterlab_toastify was created to bring an abstracted third-party library for the UI; I think the pattern should be kept to ease maintenance/evolution.
  • The material-ui Snackbar is for me missing an easy-to-use API to create toast of a specific type, to dismiss them programmatically and to have a toast following a running task (ability to update it); but this is by essence as the goal of the library is to provide nice customizable components rather that usage oriented API.

What people are using (feel free to update the list):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants