-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup to improved readonly UI: add Toast notifcations #12827
Comments
I'm splitting @isabela-pf's Toast-on-attempted-save UI proposal (described above) out from #7980 into a fresh issue here. The easy way to do this would be to incorporate an already existing quality Snackbar/Toast component, such as these fine examples:
|
I think this is the oldest issue tracking toasts: #689 |
Someone also mentioned this: https://github.com/jupyterlab-contrib/jupyterlab_toastify |
Copying here the discussion summary from the weekly meeting:
|
Additional comments:
What people are using (feel free to update the list):
|
I'm following up on my previous comment with another mockup. The first combines 1 and 2 to provide an approach that might be familiar from Notebook while having an (albeit small) icon indication in the tab as added support.
With toast notifications moving forward in #689, I think this could be a good opportunity to remind users a notebook is read-only if they try to save. I could see this being potentially annoying if it repeats, but since toasts last 10 seconds at most I think it could work if it seems like there should be an additional reminder of read-only status.
Originally posted by @isabela-pf in #7980 (comment)
The text was updated successfully, but these errors were encountered: