File editor right-click

[karlaspuldaro]

References

#2778 - Improve the right-click menu of the editor

Code changes

New commands added to file editor right-click menu:

• Undo
• Redo (new icon added)
• Cut
• Copy
• Paste
• Select all

User-facing changes

When right clicking on a file editor with a text selection:

When there is no text selection, cut and copy buttons are disabled

Backwards-incompatible changes

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[karlaspuldaro]

Note:
Copy command is only enabled if a text selection is detected on the editor. Right-clicking on a different line than the selected line unselects the text. This is a file editor behavior also present with shift+right click menu.

[blink1073]

Thanks @karlaspuldaro! So far this looks good to me overall, can you please take it out of draft when it is ready for a full review?

[karlaspuldaro]

Thank you @blink1073 , will do :)
I thought it would be helpful to start an early PR and get feedback as new commands are added.
I also debated whether each one should have its own issue/PR to limit the feature scope and create individual deliverables.

[blink1073]

I'd say it is fair to add the ones you highlighted here in this PR.

[lresende]

LGTM

[echarles]

I have tried this PR in --dev mode and it work great! copy/paste, undo/redo do their job. Yeah #8590 would allow to disable undo/redo but this is good for now.

I have also run jupyter lab build but running the build does not show the expected menus. Maybe something on my env... @karlaspuldaro worth to double check and confirm.

Also as follow-up, it would be super to add those copy/paste undo/redo to the cell editor which is already well populated, but miss those basic features.

[karlaspuldaro]

Hi @echarles
Thanks for your feedback. I just tried a new build and it works for me, I use a conda env. Did you run lab in dev mode after your build?
I follow the multiple build steps for dev documented here, where jupyter lab build is the very last step.

And I agree it would be helpful to add these features to notebook cells. Is there an open issue for it?

[ajbozarth]

LGTM

[blink1073]

Thanks @karlaspuldaro! @saulshanabrook this is backwards compatible if you want to include it in 2.2.

[saulshanabrook]

@blink1073 Sounds good!

[echarles]

@karlaspuldaro sorry missed your comment. Good to know it works in dev mode. It was for sure something in my env...

[ianhi]

Hey sorry for the late input on this, there are two things I'd like to bring up:

1. Awesome!
2. On Firefox Paste doesn't work on and currently just silently (to the user) fails
   In this gif i'm on firefox 75 on linux and first copy with contextmenu then try pasting with context menu, finally i use crtl-v to paste which does work.
   

I believe this is because (https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/readText)

Firefox only supports reading the clipboard in browser extensions, using the "clipboardRead" extension permission.

It's possible that document.exec('paste') would be workaround here?

Also, the extra console.log are not from me (i'm running the current master here) they are from

jupyterlab/packages/application/src/shell.ts

Line 780 in 5dc3859

console.log(current.content.title.label);

[karlaspuldaro]

Hi @ianhi
Since this has been merged, would you mind opening an issue for the firefox bug on paste command? I can propose a patch for that.
Thanks for the feedback :)