Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change toc to use labicon #8692

Merged
merged 6 commits into from Jul 27, 2020
Merged

Conversation

marthacryan
Copy link
Member

References

Fixes #8557.

Code changes

  • Removes the icons from the style folder
  • Adds icons that aren't already in ui-components
  • Substitute code that uses css to add icons with code that uses imported icons from ui-components

User-facing changes

Here's the current ToC:
image

Here's the updated ToC:
image

Because there was already a markdown icon in ui-components, I used that icon instead of what was being used. Also, the "collapse" button is slightly smaller and a slightly lighter color. Otherwise, looks around the same.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. tag:CSS For general CSS related issues and pecadilloes labels Jul 16, 2020
@blink1073 blink1073 added this to the 3.0 milestone Jul 17, 2020
@marthacryan
Copy link
Member Author

@kgryte How does this look to you? There were some icons that I removed without replacing them because I couldn't find where they were used ( such as the eyeball icons ) - I figured they had stopped being used at some point and been left in that folder, but if not I can add them to LabIcon too. Thanks!

@kgryte
Copy link
Member

kgryte commented Jul 27, 2020

LGTM. Those icons predate my involvement with the ToC extension, so, if you could not find a use and everything looks the same, then deleting any extra icons seems fine to me.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 341550d into jupyterlab:master Jul 27, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:toc pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ToC icon usage to LabIcon
3 participants