New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change toc to use labicon #8692
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
@kgryte How does this look to you? There were some icons that I removed without replacing them because I couldn't find where they were used ( such as the eyeball icons ) - I figured they had stopped being used at some point and been left in that folder, but if not I can add them to LabIcon too. Thanks! |
LGTM. Those icons predate my involvement with the ToC extension, so, if you could not find a use and everything looks the same, then deleting any extra icons seems fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
References
Fixes #8557.
Code changes
style
folderui-components
ui-components
User-facing changes
Here's the current ToC:
Here's the updated ToC:
Because there was already a markdown icon in
ui-components
, I used that icon instead of what was being used. Also, the "collapse" button is slightly smaller and a slightly lighter color. Otherwise, looks around the same.