PR: Localize strings in JLab

[goanpeca]

References

Code changes

User-facing changes

Backwards-incompatible changes

To be completed:

1. File/Edit/Kernel/Run menu extensions that used constants for action/noun/plural/name have now been replaced to functions that take the amount of items so that the pluralization can be correctly handled for different languages.

2. IEditorServices provides now 2 functions getFactoryService, getMimeTypeService(that accept an optional translator instead of factoryService and typeService.

/**
 * Code editor services.
 */
export interface IEditorServices {
  /**
   * The code editor factory.
   */
  getFactoryService(translator?: ITranslator): IEditorFactoryService;

  /**
   * The editor mime type service.
   */
  getMimeTypeService(translator?: ITranslator): IEditorMimeTypeService;
}

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[blink1073]

I'll be afk for the next 3 hours or so, but will be focusing on getting this done after that.

[goanpeca]

I'll be afk for the next 3 hours or so, but will be focusing on getting this done after that.

As far as I can tell there I sno need to change any API, except for the noun and plural stuff in the menus (and even we could make the changes optional and backwards compatible anyway). So I could open a PR just with that and make the rest of the changes in separate PRs and not in a hurry.

Still let's talk to go over the details. Thanks!

[blink1073]

Reviewed the first 110 files

[blink1073]

I didn't look closely at the FIXME comments in this pass

[goanpeca]

I didn't look closely at the FIXME comments in this pass

Looking into them after I make the next push (moving the factories changed a lot, so that is also a breaking change I guess... since It is also being used in the exampleS)

[goanpeca]

I also changed the FIXME: comments to FIXME-TRANS: so we can tackle them faster.

[blink1073]

To fix examples:

• add @jupyterlab/translation-extension to examples/app/index.js
• add @jupyterlab/translation-extension and @jupyterlab/translation deps in examples/app/package.json
• add @jupyterlab/translation-extension and @jupyterlab/translation deps in examples/federated/core_package/package.json
• also put both them in resolutions and put the extension in extensions in that same core_package

[afshin]

I think this is causing the file browser plugin to fail:

diff --git a/packages/filebrowser-extension/src/index.ts b/packages/filebrowser-extension/src/index.ts
index 90f662256..190e35c96 100644
--- a/packages/filebrowser-extension/src/index.ts
+++ b/packages/filebrowser-extension/src/index.ts
@@ -158,7 +158,7 @@ const factory: JupyterFrontEndPlugin<IFileBrowserFactory> = {
   activate: activateFactory,
   id: '@jupyterlab/filebrowser-extension:factory',
   provides: IFileBrowserFactory,
-  requires: [ILabShell, IDocumentManager, IDocumentManager, ITranslator],
+  requires: [ILabShell, IDocumentManager, ITranslator],
   optional: [IStateDB, IRouter, JupyterFrontEnd.ITreeResolver]
 };

[goanpeca]

Thanks for the help @afshin ! I will add a check for number of parameters on requires and also check if a same plugin has been registered before. That very stupid error on my side was not providing the right feedback :-p

[blink1073]

Let's merge and iterate