Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move title panel to inside the center content area #9268

Closed
wants to merge 4 commits into from

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Nov 3, 2020

References

Fixes issues brought up in #9105

#9274 is an alternative to this PR that preserves the existing title-at-the-top behavior.

After playing with both alternatives a bit, I like #9274 (combined with #9270) over this PR.

Code changes

User-facing changes

This prevents the menu from jumping up and down when toggling single-document mode. Also, it mirrors where the tabs are in normal mode, so it’s easy to see the correspondence between the tab title and the titlebar.

This is an experiment to see if it improves the UX overall, at least good enough to ship for 3.0. It also takes out some hacks we had with the icon to the left of the menu floating up above the bar it was on, etc.

Jumping from before (see #9105):

sdm-click

No jumping now:

sdm

Before

Screenshot_2020-11-03 JupyterLab(4)
Screenshot_2020-11-03 JupyterLab(3)

Screenshot_2020-11-03 JupyterLab(5)

After

Screenshot_2020-11-03 JupyterLab(2)
Screenshot_2020-11-03 JupyterLab(1)
Screenshot_2020-11-03 JupyterLab

Backwards-incompatible changes

@jasongrout jasongrout added this to the 3.0 milestone Nov 3, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

This prevents the menu from jumping when switching to single-document mode. However, the title gets confusing when having the left sidebar open because it looks like the document title is the header for the sidebar.
This prevents the menu from jumping up and down when toggling single-document mode. Also, it mirrors where the tabs are in normal mode, so it’s easy to see the correspondence between the tab title and the titlebar.
@jasongrout
Copy link
Contributor Author

Another approach is that we create a new single-document mode menu bar under the top bar. In single-document mode, we move the menu to the bar under the top area, and replace the menu with the title widget. That way the top bar stays on top, and only the menu moves, and you get the UX that we have now of the title at the very top. You still have a problem of menu jumping (if you switch the mode using the menu), but that's probably way less frustrating than the switch jumping.

@jtpio
Copy link
Member

jtpio commented Nov 3, 2020

Nice, thanks!

It's possible this removes a bit of the "classic notebook look and feel" by moving the title down. But the fact that it fixes the jumping seems to outweigh it 👍

@jasongrout
Copy link
Contributor Author

There is another alternative to the ux over at #9274

@jasongrout
Copy link
Contributor Author

Closing in preference for #9274

@jasongrout jasongrout closed this Nov 5, 2020
@jasongrout jasongrout modified the milestones: 3.0, Reference Nov 5, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Design System CSS pkg:application pkg:mainmenu status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants