Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tsconfig for the translation extension #9357

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 17, 2020

References

Caught while doing a full text search on some tsconfig options.

Code changes

Cleanup the tsconfig.json for the translation extension to align with the rest of the packages.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aweosme thanks @jtpio :)

@jtpio jtpio merged commit 3480963 into jupyterlab:master Nov 19, 2020
@jtpio jtpio deleted the translation-tsconfig branch November 19, 2020 09:46
@jtpio jtpio added this to the 3.0 milestone Nov 19, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:translation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants