Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split contribution guidelines into web-based and local instructions #9540

Merged
merged 7 commits into from
Jan 4, 2021

Conversation

jd41
Copy link
Contributor

@jd41 jd41 commented Jan 3, 2021

Happy new year. This PR implements the suggestion developed in #9259 to split the dev guidelines into a web-based and local version.

It makes it clear to a larger group of people that a contribution is possible without installing anything - e.g. I had never heard of binder before showing up here.

I also replaced the launch-binder image link by a regular link. I didn't see how to work the previous image into the writing in a good way.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@blink1073 blink1073 merged commit 368ba06 into jupyterlab:master Jan 4, 2021
@blink1073 blink1073 added this to the 3.0 milestone Jan 4, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants