Upgrade extension to JupyterLab 4 #31
Conversation
|
|
jupyterlab_pygments/_version.py
Outdated
| # This file is auto-generated by Hatchling. As such, do not: | ||
| # - modify | ||
| # - track in version control e.g. be sure to add to .gitignore | ||
| __version__ = VERSION = '0.2.2' |
There was a problem hiding this comment.
This file should be removed from git
RELEASE.md
Outdated
|
|
||
| Here is a summary of the steps to cut a new release: | ||
|
|
||
| - Fork the [`jupyter-releaser` repo](https://github.com/jupyter-server/jupyter_releaser) | ||
| - Add `ADMIN_GITHUB_TOKEN`, `PYPI_TOKEN` and `NPM_TOKEN` to the Github Secrets in the fork | ||
| - Add `ADMIN_GITHUB_TOKEN`, `PYPI_TOKEN` and `NPM_TOKEN` to the [Github Secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets) in the repository |
There was a problem hiding this comment.
We should ensure the package is properly set up. I'm actually not sure.
There was a problem hiding this comment.
I don't have experience releasing jupyterlab_pygments and I don't have access to see what is available in the repo, so I'm not sure if the previous releases have been done with jupyter_releaser from the repo or not? Maybe @martinRenou could provide some insight to this?
I would be happy to try to help with that or I can restore the previous instructions if those are more appropriate, they seemed to be as outlined in https://jupyter-releaser.readthedocs.io/en/latest/get_started/making_release_from_releaser.html
There was a problem hiding this comment.
Maybe we can set up the PyPI trusted publisher for this repo directly.
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
|
Should this PR be rebooted using the extension upgrade script? https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script This would help pick up the latest changes to the extension template. |
|
Is there any chance of this getting revived? I do miss having decent syntax highlighting. |
@jtpio @RRosio It would be great if this problem was solved soon. Can you please coordinate with each other? Thank you. |
|
Hi, I'm happy to contribute to this, is the main issue blocking the MR from being merged the uncertainty around the release process? |
|
I do not think that the release process is a blocker in itself. It is more of a matter of restarting using the script: |
|
Superseded by #38 |
No description provided.