Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple /tree handler. #31

Merged
merged 3 commits into from
Dec 23, 2017
Merged

Conversation

afshin
Copy link
Member

@afshin afshin commented Dec 14, 2017

This PR provides a handler for all URLs that begin with the tree_url prefix. The default value for tree_url is /lab/tree/. The handler returns exactly what the LabHandler returns for HTTP get requests because it is simply an instance of the LabHandler that matches a permissive regular expression.

The JupyterLab front-end will need to read the URL and decide how to manifest the URL in the application state (e.g., open a folder or a notebook, etc.): jupyterlab/jupyterlab#3396

@ellisonbg
Copy link
Contributor

I posted this comment on jupyterlab/jupyterlab#3396 as well:

We should add a low priority handler to /lab/* that makes sure that any 404 with the /lab prefix routes the user to lab, and not the default server 404 page.

Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add low-priority /lab/* handler that redirects to /lab

@blink1073
Copy link
Contributor

Thanks!

@blink1073 blink1073 merged commit c8d5c5b into jupyterlab:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants