-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation for jupyter-archive #108
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks for starting this, you are very welcome! For the strings to show up on crowdin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing. Unfortunately the first step would be to add translation mechanism in the extension itself in the repository as mentioned by Michal. I can give you some pointers if you are willing to open a PR to do so.
@fcollonval Can you give some instructions of how to add translation mechanism in jupyter_archive? I can open an PR for that, Thx |
can I just do with jupyter_archive like the file changes in jupyterlab-tour? |
Yes this is the idea. Be careful that that PR was not totally correct as it was not following the naming for the translator objects. See the documentation for the rules to follow. |
already add a pr in jupyter_archive, can you check it |
Now that jupyterlab-contrib/jupyter-archive#68 is merged. Let's merge this one. Thanks again @eastonsuo |
Want to contribute for translation of jupyter-archive in zh_CN