Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for jupyter-archive #108

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

eastonsuo
Copy link
Contributor

Want to contribute for translation of jupyter-archive in zh_CN

@welcome
Copy link

welcome bot commented Sep 28, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski
Copy link
Member

Thanks for starting this, you are very welcome! For the strings to show up on crowdin jupyter-archive would need to be first updated to include trans.__ wrappers, as in jupyterlab-contrib/spellchecker#84 or jupyterlab-contrib/jupyterlab-tour#24) - otherwise merging this pull request will not suffice.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing. Unfortunately the first step would be to add translation mechanism in the extension itself in the repository as mentioned by Michal. I can give you some pointers if you are willing to open a PR to do so.

@eastonsuo
Copy link
Contributor Author

eastonsuo commented Sep 29, 2021

@fcollonval Can you give some instructions of how to add translation mechanism in jupyter_archive? I can open an PR for that, Thx

@eastonsuo
Copy link
Contributor Author

can I just do with jupyter_archive like the file changes in jupyterlab-tour?

@fcollonval
Copy link
Member

can I just do with jupyter_archive like the file changes in jupyterlab-tour?

Yes this is the idea. Be careful that that PR was not totally correct as it was not following the naming for the translator objects. See the documentation for the rules to follow.

@eastonsuo
Copy link
Contributor Author

already add a pr in jupyter_archive, can you check it

@fcollonval
Copy link
Member

Now that jupyterlab-contrib/jupyter-archive#68 is merged. Let's merge this one. Thanks again @eastonsuo

@fcollonval fcollonval merged commit a40851d into jupyterlab:master Sep 29, 2021
@welcome
Copy link

welcome bot commented Sep 29, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants