Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the standby value generated instead of ignoring it. #30

Merged
merged 1 commit into from Dec 17, 2019
Merged

Use the standby value generated instead of ignoring it. #30

merged 1 commit into from Dec 17, 2019

Conversation

jasongrout
Copy link
Contributor

The standby value generated in the line above is ignored in the current code if it is a boolean. This makes it actually be used where intended.

@jasongrout
Copy link
Contributor Author

CC @afshin

afshin
afshin approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; that was a bug.

👍

@afshin afshin merged commit aea17f4 into jupyterlab:master Dec 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasongrout @afshin