Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents enter from being interpreted as emoji #563

Merged
merged 1 commit into from Mar 22, 2023
Merged

Conversation

JasonWeill
Copy link
Contributor

Fixes #540.

Prevents ENTER from being interpreted as an emoji character on Mac. Updates examples.

image

@welcome
Copy link

welcome bot commented Mar 21, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill JasonWeill added the bug Something isn't working label Mar 21, 2023
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fcollonval fcollonval merged commit d577cc9 into main Mar 22, 2023
17 of 19 checks passed
@welcome
Copy link

welcome bot commented Mar 22, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval deleted the shortcut-emoji branch March 27, 2023 07:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS: Emoji used for "enter" in pulldown menu keyboard shortcuts
3 participants