Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Actual Return character for Mac shortcuts. #592

Merged
merged 1 commit into from Jun 13, 2023

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Jun 12, 2023

The current character is "Leftwards Arrow with Hook" U+21A9 https://www.compart.com/en/unicode/U+21A9 from the "Arrows" block which often is rendered as colored emoji (CF code where U+FE0F Variation Selector-16) was added.

Replace with "Return Symbol" U+23CE from the "Miscellaneous Technical", which is more consistent as many of the other characters in this list are also from the "Miscellaneous Technical" section (Backspace, Alt, Shift..)

This should not need the Variation Selector and will have a similar look to Shift/Maj... in most fonts.

The current character is "Leftwards Arrow with Hook" U+21A9
https://www.compart.com/en/unicode/U+21A9  from the "Arrows" block
which often is rendered as colored emoji (CF code where U+FE0F Variation
Selector-16) was added.

Replace with "Return Symbol" U+23CE from the "Miscellaneous Technical",
which is more consistent as many of the other characters in this list
are also from the "Miscellaneous Technical" section (Backspace, Alt,
Shift..)

This should not need the Variation Selector and will have a similar look
to Shift/Maj... in most fonts.
@welcome
Copy link

welcome bot commented Jun 12, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Carreau
Copy link
Contributor Author

Carreau commented Jun 12, 2023

@JasonWeill You were the one who added the Variation Selector 16 recently, maybe you will like this change :-)

@JasonWeill JasonWeill added the enhancement New feature or request label Jun 12, 2023
Copy link
Contributor

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Carreau
Copy link
Contributor Author

Carreau commented Jun 12, 2023

Nice work!

I wouldn't have though of the VS16 ! But I guess we are both triggered by emojis in menus :-)

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Carreau

@fcollonval fcollonval merged commit 507f027 into jupyterlab:main Jun 13, 2023
16 of 19 checks passed
@welcome
Copy link

welcome bot commented Jun 13, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

gabalafou pushed a commit to gabalafou/lumino that referenced this pull request Jul 7, 2023
The current character is "Leftwards Arrow with Hook" U+21A9
https://www.compart.com/en/unicode/U+21A9  from the "Arrows" block
which often is rendered as colored emoji (CF code where U+FE0F Variation
Selector-16) was added.

Replace with "Return Symbol" U+23CE from the "Miscellaneous Technical",
which is more consistent as many of the other characters in this list
are also from the "Miscellaneous Technical" section (Backspace, Alt,
Shift..)

This should not need the Variation Selector and will have a similar look
to Shift/Maj... in most fonts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants