Optional prevent default and asynchronous hold for keybinding execution #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #688
preventDefault
option toIKeyBinding
andIKeyBindingOptions
to enable downstreams to opt out of preventing default on the processed keyboard eventsCommandRegistry.holdKeyBindingExecution(event: KeyboardEvent, permission: Promise<boolean>): void;
method which enables downstream to hold the execution of a keybinding until the permission to execute resolves totrue
, or to prevent it if it resolves withfalse