Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert renaming the config properties #62

Merged
merged 1 commit into from Jun 28, 2022
Merged

Revert renaming the config properties #62

merged 1 commit into from Jun 28, 2022

Conversation

martinRenou
Copy link
Member

jtpio
jtpio approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks good for keeping things consistent.

@martinRenou martinRenou merged commit 80da83e into jupyterlite:main Jun 28, 2022
@martinRenou martinRenou deleted the revert_rename branch June 28, 2022 08:35
jasongrout added a commit to jasongrout/jupyterlite-sphinx that referenced this pull request Aug 17, 2022
@jasongrout
Finish reverting config names.
a7262ea 
In jupyterlite#62, we reverted the config name changes from jupyterlite#58. However, we forgot to revert the changes to our docs conf.py config as well.
@jasongrout jasongrout mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinRenou @jtpio