New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when loading settings from federated extensions #1213
Comments
Installing the {
"extension": "./extension",
"liteExtension": false,
"load": "static/remoteEntry.749fd42299b69250a475.js",
"name": "@jupyter-notebook/lab-extension",
"style": "./style"
} The commands are available in the command palette, but the menu and toolbar items are missing: So there might be a more general issue of loading settings from a federated extension (to be confirmed). |
Looking more into it, there does seem to be a more general issue with toolbar items and menu entries (defined via the settings). This is for example reproducible with https://github.com/jupyterlab/extension-examples/tree/main/toolbar-button. For now not sure if it's related to a upstream change in JupyterLab 4 w.r.t how the settings are loaded. Next step would be confirm that settings based items and menu entries used to work fine in JupyterLite 0.1.0 built on JupyterLab 3. |
Maybe related to jupyterlab/jupyterlab#14195 ? |
JupyterLab 4 now seems to be expecting all settings to be returned in one call at application startup. I guess we can work around that in JupyterLite by moving (or just copying) the Another option would have been to aggregate all the settings from federated extensions at runtime via In the future this might be an issue for deployments setups that would like to load extensions from a CDN or other hosts, since these extensions and their settings would not be known by the application at startup. |
yeah, i wouldn't worry too much about that case until someone shows up with a concrete issue... there are so many cases of extension code constructing URLs from |
This is tracked upstream and would indeed likely require some other changes anyway: jupyterlab/jupyterlab#8866 |
Description
Currently the JupyterLab app is missing a menu entry to open Notebook 7 in a new browser tab.
Reproduce
On https://jupyterlite.readthedocs.io/en/latest/_static/lab/index.html :
Expected behavior
It should be possible to open Notebook 7 from JupyterLab like with JupyterLite 0.1.x using RetroLab:
But using the existing Notebook 7 extension that adds the following menu entry:
Context
Follow-up to #1019.
The text was updated successfully, but these errors were encountered: