New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4 and Notebook 7 #1019
Conversation
Opening early mostly to find potential issues with the lab 4 and notebook 7 pre-releases before they enter beta and rc phases. Still planning to cut a |
399ea8b
to
cbb15b5
Compare
f3a5d4e
to
6a15c8b
Compare
d425fcb
to
1d1bf40
Compare
6a4be60
to
b1df3e0
Compare
Made a couple of edits based on the suggestions above. Some remaining suggestions are not strictly related to the update to the lab 4 and notebook 7 packages and could be addressed as follow-ups. I would like to proceed with the merge of this PR and release a first |
Welp, we did set it up so they can already get started with a manual download of the wheels:
But of course all the npm Will take a look at some more of the code changes, but from test driving on RTD: Hard blockers:
Core stuff:
Extension stuff:
|
This is not going to help if the downstreams also want to make pre-releases.
Not sure they are all hard blockers for a first alpha release...
Yeah also noticed that one, which might look similar to jupyter/notebook#7002. |
Some of the Mathjax / ipywidgets issues might be related to jupyter-widgets/ipywidgets#3829 |
That one might be related to jupyterlab/jupyterlab#14962, or jupyterlab/jupyterlab#13792 / jupyterlab/jupyterlab#13851. |
Some quick findings on RTD:
|
Opened #1141 to track follow-ups and remaining issues. I'll look into these issues right after. And also planning to make a first Thanks all for the reviews! |
References
Fixes #826
Fixes #925
Fixes #262
Closes #457
Code changes
@jupyterlab
and@lumino
packagesjlpm
for development@jupyter-notebook
(Notebook 7) packages@jupyterlab/lsp-extension
@jupyterlab/metadataform-extension
@jupyterlab-apputils-extension:announcements
ws://localhost:8000/api/events/subscribe
or disable events for now?lsp/status
endpointedit
consoles
notebooks
tree
jupyterlite/packages/retro-application-extension/src/index.ts
Lines 46 to 77 in fa5f44f
4.0.5
packages fixes ittrace
. Fixes Pipe the UI tests console messages to a file on CI #925/lab
,/tree
...JupyterLab extensions to update to JupyterLab 4
jupyterlab_miami_nights
: JupyterLab 4 and build / CI tool uplift timkpaine/jupyterlab_miami_nights#57jupyterlab-drawio
: support for JupyterLab 4.0 QuantStack/jupyterlab-drawio#119jupyterlab-github
: Upgrade extension to JupyterLab 4 jupyterlab/jupyterlab-github#145jupyterlab-kernelspy
: Update to JupyterLab 4 jupyterlab-contrib/jupyterlab-kernelspy#90jupyterlab-markup
jupyterlab-myst
: 🪐 Support for JupyterLab 4.x (take 2!) executablebooks/jupyterlab-myst#155theme-darcula
User-facing changes
Maybe user facing changes are similar to the JupyterLab 4 and Notebook 7 changes:
Backwards-incompatible changes
Same as JupyterLab 4 for extension authors.
Follow-ups
Follow the same-> done ✔️/tree
,/edit
,/notebooks
as the regular Notebook, instead of keeping the notebook app under/notebook
Add workflow to update the playwright snapshots, like in the notebook repo: https://github.com/jupyter/notebook/blob/main/.github/workflows/playwright-update.yml-> added, need to be testedRethink how to build the JupyterLite apps: bottom-up or top-down +->disabledExtensions
? (see also Add a check to ensure upstream plugins and extensions are included in the build #1022)tree
,consoles
,notebooks
... are their own apps withdisabledExtensions