New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load all settings from federated extensions at startup #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollwyvl
reviewed
Oct 19, 2023
bollwyvl
reviewed
Oct 19, 2023
py/jupyterlite-core/jupyterlite_core/addons/federated_extensions.py
Outdated
Show resolved
Hide resolved
bollwyvl
reviewed
Oct 19, 2023
bollwyvl
reviewed
Oct 19, 2023
Thanks @bollwyvl for the review, I pushed a couple more commits to address the suggestions 👍 |
Getting this one in and following up with a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JupyterLab 4 seems to now be expecting all settings (including the ones from federated extensions) to be returned in one go on the first call to
/api/settings
.This is likely related to the change in jupyterlab/jupyterlab#14195 and/or other upstream PRs as well.
Fixes #1213
Code changes
all_federated.json
file by adding a step in thefederated_extensions
addonpost_build
notebook
package is installed in the build environment/doc/tree
notebook
package in the docs to get the UI elementsAn alternative could have been to create an
all.json
file with all the settings for a federated extension, in each federated extension directory. And query this file for each extension. However many extensions don't provide settings, so these queries would lead to many 404s.User-facing changes
End users should be able to see menu entries or toolbar items defined in third-party extensions via the settings system.
notebook-lab-switch.mp4
Backwards-incompatible changes
None