Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4 and Notebook 7 #1019
Update to JupyterLab 4 and Notebook 7 #1019
Changes from all commits
5487b92
96ce2df
4f60392
7910e5c
b1646fc
cef7a25
f6bbf07
46c52e2
1acfec0
57ddf99
1715454
89e3f35
07820db
f71b17a
63ac96b
c13c83f
249d25d
fa992c9
33e4b90
f088999
27d4a4b
5b35398
c3df092
dee6375
9bb0d95
6075bdd
617c268
17e39e1
31d5d83
dbfd6dc
d93aa6c
57784cc
166c4d0
552f99c
fda7b47
adec31f
997b4f2
f546b22
4de75b5
86d01d7
4749349
7def1ca
50b2b0b
2460cd9
fb0ae2a
dca09f3
c7efe96
cca11f0
f67823d
2e67f84
c25a4e4
f8ba8b3
b241109
f9300a2
3f1d51e
ccfff4f
d07f207
dd5a97f
76ec1f0
8bc3b90
97fd053
8f5099c
3a7b288
dc28d33
cd14a26
41f7d78
37a09c6
b6fb004
94cf098
15de5b9
48876e7
c18aa3e
f78c29d
a7559b6
e0bc35c
9f665e1
dce169b
d9febe3
b71725d
f7981fb
955a374
1597da5
100bb4e
e76ed36
caeb6c5
60120ec
75aab4c
ebc6fb7
4210387
97d08dd
76813bd
c48f110
fbc2477
8eb430c
6dd5905
07d0552
3bf4d6d
68255b4
0ee201a
1457271
4155195
aed578b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the config to not use junk up the root with
pnp
? Or not use thepnp
features at all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't
.pnp
already ignored on the line below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point would be to remove all the added
.yarn
and.pnp
entries from the.gitignores
and never see them on diskpnp
?.pnp
/.yarn
at all, if possiblenode_modules
nx
orlerna
or whatever to be happy,build/.(pnp|yarn)
or somethingAs I've been exploring these new "features," (still haven't found what value the new
yarn
adds, other than an incompatible lockfile) I've ended up with some patterns like this to improve the cacheability ofnode_modules
and reduce the extreme amount of noise from e.g.jlpm
:As well as some env vars:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we should have this configuration here in the JupyterLite repo and not upstream in the JupyterLab repo?
If not, should we open an issue about it in the JupyterLab repo? (or maybe there is already one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, dunno... this is purely from a "digging out from under a mountain of extensions" perspective, again, haven't really been tracking what upstream is doing with the new
yarn
stuff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, and this could also go into
package.json
(unlikeprettierignore
, for some reason, buh)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, on the "clean up the root" tip, could move these few lines into
package.json
.This file was deleted.