Clean up log messages, flaky tests on Windows #1183
Conversation
|
|
|
I'm not going to lie: having to dig around for multiple slow lint subcommands vs |
bollwyvl
changed the title
|
The RTD setup is down to fits-on-a-page. The We could hide the |
|
Bah, still local network flake... not much we can do about that, i guess... |
| @@ -4,3 +4,16 @@ enableTelemetry: false | |||
| httpTimeout: 60000 | |||
| nodeLinker: node-modules | |||
| npmRegistryServer: 'https://registry.yarnpkg.com' | |||
|
|
|||
| # logFilters codes described: https://yarnpkg.com/advanced/error-codes | |||
| logFilters: | |||
There was a problem hiding this comment.
Questions:
- isn't there a way to properly fix or handle these warning, instead of ignoring them?
- likely these also happen in the JupyterLab / Notebook repos? If so should we suggest updating the configuration there? So the JupyterLite repo does not do things too differently
- let's move this yarn config (and the discussion) to a separate PR, so it will be easier to track and find it in the future?
There was a problem hiding this comment.
properly fix or handle these warning
Most (by count in an install) aren't warnings, but rather low-level play-by-play of needing to/downloading/filling the cache. Indeed, it is almost certainly making installs slower even trying to formulate the entries, even if they don't get printed
The warnigns that do remain, and fit on a page (as posted) are potentially worth investigating, which can only be determined by actually showing the log, reading what is says, and recognizing the shape.
happen in the JupyterLab / Notebook repos?
It looks like upstream might relegate the yarn call to inside hatch (inside another, temporary environment), none of which are cached, so that logs only make it out if it full explodes, and maybe not then.
This happens so often, is so slow, and is so noisy, i reckon folk just had to tune it out. But it makes trying to find anything in build logs rather awful. i'm assuming nobody looks unless it fully breaks the build, in which case one is debugging hatch, special non-standard hatch stuff, yarn, lerna, node, etc. all at the same time.
This is also all the more reason to restore the loss of YARN_HISTORY being node_modules/.yarn-state.yml, so that install is called less frequently.
There was a problem hiding this comment.
This is also all the more reason to restore the loss of
YARN_HISTORYbeingnode_modules/.yarn-state.yml, so that install is called less frequently.
Maybe also worth suggesting upstream?
There was a problem hiding this comment.
Pushed a small commit to align the comment with the one in jupyterlab/jupyterlab#15214.
References
Code changes
pytest-console-scripts 1.4.0yarn installnoise about cache/rebuildUser-facing changes
Backwards-incompatible changes