Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open file via URL params in JupyterLab #380

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Open file via URL params in JupyterLab #380

merged 4 commits into from
Oct 11, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 10, 2021

References

Fixes #379

Code changes

We already had some logic for RetroLab in the @jupyterlite/retro-application-extension:opener plugin.

This change moves the plugin to @jupyterlite/application-extension so it's more generic and handle both lab and retro.

User-facing changes

Users can share links to notebooks so they automatically open in the JupyterLab interface:

https://jupyterlite--380.org.readthedocs.build/en/380/_static/lab/index.html?path=pyolite.ipynb

Also handle /lab/tree for consistency with upstream JupyterLab:

https://jupyterlite--380.org.readthedocs.build/en/380/_static/lab/tree/index.html?path=pyolite.ipynb

open-file-lab.mp4

Backwards-incompatible changes

None

@jtpio jtpio added the enhancement New feature or request label Oct 10, 2021
@jtpio jtpio added this to the 0.1.0 milestone Oct 10, 2021
@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

@jtpio
Copy link
Member Author

jtpio commented Oct 10, 2021

cc @MrityunjayBhardwaj if you want to give it a try on the ReadTheDocs preview:

open-file-lab-rtd.mp4

@jtpio jtpio mentioned this pull request Oct 11, 2021
@jtpio jtpio marked this pull request as ready for review October 11, 2021 08:19
@jtpio
Copy link
Member Author

jtpio commented Oct 11, 2021

We can look into the "Copy Shareable Link" command and opening in the simple interface in #382

@jtpio jtpio merged commit b874889 into jupyterlite:main Oct 11, 2021
@jtpio jtpio deleted the open branch October 11, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant