Version piplite with the bump-version script
#421
Conversation
|
|
|
Looks good testing locally with the releaser assets:
|
scripts/bump-version.py
Outdated
| @@ -23,8 +23,9 @@ | |||
|
|
|||
| PYOLITE_PACKAGE = ROOT / "packages" / "pyolite-kernel" | |||
| PYOLITE_PACKAGE_JSON = PYOLITE_PACKAGE / "package.json" | |||
| PYOLITE_KERNEL_SOURCE = PYOLITE_PACKAGE / "src" / "kernel.ts" | |||
| PYPI_SOURCE = PYOLITE_PACKAGE / "src" / "_pypi.ts" | |||
There was a problem hiding this comment.
hmmm... this file gets generated.
There was a problem hiding this comment.
The real source of truth migh tbe: https://github.com/jupyterlite/jupyterlite/blob/main/packages/pyolite-kernel/package.json#L69 (unless that's covered above)
There was a problem hiding this comment.
Maybe this one is not needed actually, gonna double check.
There was a problem hiding this comment.
This gets regenerated by doit build:js:piplite:wheels, so if that happens after this runs...
|
|
||
| # bump pyolite version | ||
| pyolite_json = json.loads(PYOLITE_PACKAGE_JSON.read_text(**ENC)) | ||
| pyolite_json["pyolite"]["packages"]["py/pyolite"] = py_version | ||
| pyolite_json["pyolite"]["packages"]["py/piplite"] = py_version |
|
Also since this string search / replace is a bit brittle, it should probably just fail it if fails to do the replace. So the check release CI check would be able to catch future changes. |
jtpio
force-pushed
the
version-piplite
branch
from
d965ed4
to
fda0358
Compare
|
This seems to be looking good now. Let's merge and I'll make a release later today. |
References
Fixes #420
Code changes
Update the
bump-version.pyscript to version the packages, as a follow-up to #310.User-facing changes
So the following code snippet:
Gives a consistent version.
Backwards-incompatible changes
None