Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Use appUrl and file name for shareable link #457

Closed
wants to merge 4 commits into from
Closed

[wip] Use appUrl and file name for shareable link #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07eb94d
use full html url for shareable link
bollwyvl Jan 20, 2022
612910c
add command palette entry for shareable link
bollwyvl Jan 20, 2022
a101035
use appUrl for shareable link
bollwyvl Jan 20, 2022
a436f2f
revert command palette, fix appUrl/baseUrl usage
bollwyvl Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions dodo.py
View file
Open in desktop
Expand Up @@ -919,6 +919,7 @@ class L:
ALL_ESLINT = _clean_paths(
P.PACKAGES.rglob("*/src/**/*.js"),
P.PACKAGES.rglob("*/src/**/*.ts"),
P.PACKAGES.rglob("*/src/**/*.tsx"),
)
ALL_JSON = _clean_paths(
P.PACKAGE_JSONS,
Expand Down
10 changes: 9 additions & 1 deletion packages/application-extension/src/index.tsx
View file
Open in desktop
Expand Up @@ -518,7 +518,15 @@ const shareFile: JupyterFrontEndPlugin<void> = {
return;
}

const url = new URL(URLExt.join(PageConfig.getBaseUrl(), 'lab'));
const url = new URL(
URLExt.join(
PageConfig.getBaseUrl(),
PageConfig.getOption('appUrl').slice(
PageConfig.getOption('baseUrl').length
),
'index.html'
)
);
const models = toArray(
filter(widget.selectedItems(), item => item.type !== 'directory')
);
Expand Down