[wip] Use appUrl and file name for shareable link

[bollwyvl]

References

• fixes "Copy Shareable Link" issue with browser go-back function #450
• follow-on to Copy Shareable Link #382
• might address Share a link to a file from the Notebook interface #398

Code changes

• uses {appUrl}/index.html (where appUrl is usually lab) for the full link

User-facing changes

• the back button should work after redirecting (should be able to test from the rtd preview)

Backwards-incompatible changes

• n/a

Future work

We might want to open up the API to support making the shareable params configurable. For example, jupyter-video chat offers the ?jvc=room feature, and it would make sense to be able to share that room state as well.

This also initially supported the command palette, but I've rolled this back, as I didn't realize it only applied to the selection from the file tree, not the main area. This would probably be a useful feature in its own right, but would have a different name, e.g. Copy Workspace Link or something along those lines, and is probably out of scope

[github-actions]

👈 Try it on ReadTheDocs

[bollwyvl]

Hmmm... it looks like this is enabled in the retro tree, but points back to /lab/. It appears to work the same way in bog-standard retrolab.

@jtpio any thoughts on what the correct behavior should be here? I don't think it would block this, especially if it needs to be fixed upstream. I could imagine a few options (non-exclusive):

• disable the command altogether
• add a button (classic didn't use much right click, so I'm wagering folk won't expect stuff there)
• disable the command if multiple items are picked
• allow picking multiple items, open the tree, and then open all the tabs... weird, but seems like it would logically fit the idea

Anyhow, seems like RTD is having A Day... will take another look tomorrow.

[bollwyvl]

Ok, one should be able to back-button from this link:

https://jupyterlite--457.org.readthedocs.build/en/457/_static/lab/index.html?path=javascript.ipynb

No dice: it still gets consumed by the redirect. Will consider some other approaches...

[leukipp]

Related to #450 I found that router.navigate(...); is used

jupyterlite/packages/application-extension/src/index.tsx

Line 479 in 7b322c8

router.navigate(`${pathname}${search}`, { skipRouting: true });

which does a history.pushState({}, '', url);.

The history stack contains then the old url (with path parameter) and the new url (without path parameter). Going back leads to the loop behavior.

Some options involving history manipulation:

• delete current history entry before navigate
• using history.replaceState
• ...

[jtpio]

Planning to take a look later when we start updating to the JupyterLab 4 and Notebook 7 packages: #826