Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to JupyterLab 3.6.0 #898

Closed
wants to merge 8 commits into from

Conversation

fcollonval
Copy link
Contributor

This reverts commit 06c55f0.

References

Superseeds #876

Code changes

Upgrade to 3.6.0 alpha 5

User-facing changes

Use latest version

Backwards-incompatible changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

lite-badge 👈 Try it on ReadTheDocs

@martinRenou
Copy link
Member

This probably goes in conflict with #899 (also in conflict with main apparently)

@jtpio jtpio added the enhancement New feature or request label Dec 9, 2022
@jtpio jtpio added this to the 0.1.0 milestone Dec 9, 2022
@jtpio jtpio mentioned this pull request Dec 12, 2022
4 tasks
@jtpio
Copy link
Member

jtpio commented Dec 12, 2022

At the end of the JupyterLite workshop last week there were some brief discussions with @fcollonval and @hbcarlos about whether it would be worth updating JupyterLite to JupyterLab 3.6.

Since 3.6 mostly brings improvements to RTC, it can also be fine to stick to 3.5 in lite for now since https://github.com/jupyterlite/jupyterlab-webrtc-docprovider still works ok.

And focus efforts on updating to lab 4 and nb 7 directly: #826

Although it's still in draft for now, there is a chance the RTC frontend implementation will be making use of an IDrive: jupyterlab/jupyterlab#13512. This is still in discussion and not merged, but is looking like a simpler approach of enabling RTC in JupyterLab in general. JupyterLite would also benefit from it via the jupyterlab-webrtc-docprovider extension (which can be renamed later if needed) since this would mostly be encapsulated in a IDrive implementation.

@fcollonval @hbcarlos feel free to add more insights and details here if needed, or in #826.

@fcollonval
Copy link
Contributor Author

I fully agree with @jtpio

With the nice drive approach targeting 4 and as our resources are sparse, I advice to skip touching https://github.com/jupyterlite/jupyterlab-webrtc-docprovider before 4. Hence this implies not upgrading JupyterLite to 3.6.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Dec 12, 2022

This works for me! I guess it will then be relevant to continue getting upstream bugfixen to a 3.5.x branch, as well for a while, then... we can't be the only downstream that will be unable to quickly shift and throw a bunch of resources at the new ydoc-related upgrades when 4.x and notebook 7.x, which will require many other changes, are coming Real Soon Now ™️ .

@jtpio jtpio modified the milestones: 0.1.0, Future Dec 20, 2022
@jtpio jtpio mentioned this pull request Dec 22, 2022
3 tasks
@jtpio
Copy link
Member

jtpio commented Mar 22, 2023

Closing in favor of #1019 as we'll skip the update to JupyterLab 3.6.

@jtpio jtpio closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants