Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jus development stalled by Node 4 support #77

Closed
elingerojo opened this issue Sep 17, 2017 · 3 comments
Closed

jus development stalled by Node 4 support #77

elingerojo opened this issue Sep 17, 2017 · 3 comments

Comments

@elingerojo
Copy link
Member

elingerojo commented Sep 17, 2017

Events summary

  1. node-oniguruma broke Node 4 support on April 20
  2. The above make jus development imposible 'cause of Travis
  3. There has been three PRs ( Update required Node version to 6, change Travis/Appveyor Node versions to 7 #72, WIP: Remove oniguruma dependency by replacing marky-markdown by markdown-it #73 and Keep marky-markdown and still support Node v4 #74) to mitigate jus impact to no avail
  4. node-origumma problem has been fixed on Sep. 8
  5. first-mate is blocking the update to origuruma@7.0.0 in the dependency chain (marky-markdown > highlights > first-mate > oniguruma)

Issue

jus development can not be done 'cause of Travis (I have not been able to PR since April 20)

Possible options

a) Ask 'first-mate' to update oniguruma dependency

Create a first-mate PR with just one line change in their package.json. The change consist in just one character "oniguruma": "6.2.1", to "oniguruma": "^6.2.1", ...and hope it gets merged.

EDIT: The change consist in "oniguruma": "6.2.1", to "oniguruma": "7.0.0",

This may be difficult 'cause I see their tests and configurations stating Node 6 clearly and may not have an incentive to support Node 4 ...but you never know.

b) Change 'jus' Node support to 6

Create and merge a jus PR with the needed change.

@elingerojo
Copy link
Member Author

Possible options

a) Ask 'first-mate' to update oniguruma dependency

✔️ done by first-mate PR

b) Change 'jus' Node support to 6

✔️ done by jus #78


Let's see which one wins! 😕

@djfdev
Copy link
Contributor

djfdev commented Dec 19, 2017

@elingerojo Would love to see this resolved. I see there is a 3rd option implemented in #79, and it looks like tests are passing. What's the status of this?

@zeke
Copy link
Member

zeke commented Dec 20, 2017

Hey @djfdev I think it's ready to go, if @elingerojo says so.

@zeke zeke closed this as completed in #79 Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants