-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jus development stalled by Node 4 support #77
Comments
Closed
Merged
@elingerojo Would love to see this resolved. I see there is a 3rd option implemented in #79, and it looks like tests are passing. What's the status of this? |
Hey @djfdev I think it's ready to go, if @elingerojo says so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Events summary
node-oniguruma
broke Node 4 support on April 20jus
development imposible 'cause of Travisjus
impact to no availnode-origumma
problem has been fixed on Sep. 8first-mate
is blocking the update to origuruma@7.0.0 in the dependency chain (marky-markdown > highlights > first-mate > oniguruma)Issue
jus
development can not be done 'cause of Travis (I have not been able to PR since April 20)Possible options
a) Ask 'first-mate' to update oniguruma dependency
Create a
first-mate
PR with just one line change in theirpackage.json
.The change consist in just one character"oniguruma": "6.2.1",
to"oniguruma": "^6.2.1",
...and hope it gets merged.EDIT: The change consist in
"oniguruma": "6.2.1",
to"oniguruma": "7.0.0",
This may be difficult 'cause I see their tests and configurations stating Node 6 clearly and may not have an incentive to support Node 4 ...but you never know.
b) Change 'jus' Node support to 6
Create and merge a
jus
PR with the needed change.The text was updated successfully, but these errors were encountered: