Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Support for Node 4 lost in latest minor release #65

Closed
jefflembeck opened this issue Apr 20, 2017 · 5 comments
Closed

Support for Node 4 lost in latest minor release #65

jefflembeck opened this issue Apr 20, 2017 · 5 comments

Comments

@jefflembeck
Copy link

8071627#diff-4cb512c0b8c044091a83b49d95f77ddcR1

With the addition of destructuring assignments, this only supports node 6 now.
@50Wliu
Copy link
Contributor

50Wliu commented Apr 20, 2017

/cc @maxbrunsfeld

@maxbrunsfeld
Copy link
Contributor

Yup, we're generally embracing the ES6 features and assuming a recent Node version on our projects, but I'm open to a PR that adds Node 4 support back. 😕

This was referenced Apr 21, 2017
Open
Closed
@elingerojo
Copy link
Contributor

@maxbrunsfeld

On last commit of PR #66, I left the "removed" code as commented code for easy review but if you want, I can add another commit without the debris

@elingerojo elingerojo mentioned this issue May 1, 2017
Open
@jdormit jdormit mentioned this issue May 2, 2017
Open
@ashleygwilliams
Copy link

related: #70

@Ben3eeE Ben3eeE closed this as completed Sep 8, 2017
@Ben3eeE
Copy link

Ben3eeE commented Sep 8, 2017

Closed via #71

This was referenced Sep 15, 2017
Open
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jefflembeck @maxbrunsfeld @Ben3eeE @ashleygwilliams @50Wliu @elingerojo