-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - one click confirm handler #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsrivatsa-edinburgh
requested review from
arun-mi,
akash-c-k and
prafulkoppalkar
December 11, 2023 09:56
vsrivatsa-edinburgh
force-pushed
the
feat/one_click_confirm_handler
branch
2 times, most recently
from
December 18, 2023 08:33
63b4a73
to
342424c
Compare
arun-mi
reviewed
Jan 2, 2024
arun-mi
reviewed
Jan 2, 2024
arun-mi
reviewed
Jan 2, 2024
vsrivatsa-edinburgh
force-pushed
the
feat/one_click_confirm_handler
branch
from
January 17, 2024 20:01
342424c
to
c1edade
Compare
arun-mi
previously approved these changes
Feb 7, 2024
akash-c-k
previously approved these changes
Feb 7, 2024
ArushKapoorJuspay
requested changes
Feb 7, 2024
vsrivatsa-edinburgh
dismissed stale reviews from akash-c-k and arun-mi
via
February 8, 2024 09:22
b5d54f9
ArushKapoorJuspay
previously approved these changes
Feb 15, 2024
prafulkoppalkar
suggested changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
req changes
Confirm Handler for One Click Payment Methods - GPay, ApplePay, Paypal, PaypalSDK
vsrivatsa-edinburgh
force-pushed
the
feat/one_click_confirm_handler
branch
from
February 19, 2024 12:01
ba7b40a
to
30ada5c
Compare
prafulkoppalkar
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
ArushKapoorJuspay
approved these changes
Feb 20, 2024
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
bug fix Approved-by: Praful Koppalkar
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from paymentMethodChanges to master * commit '0c5ebd0257c065a606da28a0a49806887a58565a': changes for bancontact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One Click confirm Handler for GooglePay - for an embedded checkout experience