Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] move connector config to a separate file #1109

Open
2 tasks done
Narayanbhat166 opened this issue May 10, 2023 · 7 comments · May be fixed by #1404
Open
2 tasks done

[FEATURE] move connector config to a separate file #1109

Narayanbhat166 opened this issue May 10, 2023 · 7 comments · May be fixed by #1404
Assignees
Labels
C-feature Category: Feature request or enhancement E-easy Effort: Should be easy to implement and would make a good first PR good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Narayanbhat166
Copy link
Member

Narayanbhat166 commented May 10, 2023

Feature Description

Currently all the connector configuration is present in the development.toml file. But this configuration is not developer specific, this remains the same whoever uses it, this configuration is based on the application and it should not be tweaked by the developer or else it would cause some features to not work.

Possible Implementation

Move the configuration to a separate file and if possible in a better format ( the layout and keys can be changed as per the needs, but file format has to be TOML only ) so that the application can read it easily. After making this change, all the places where this config is read has to be changed to read from a single file.

Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

No, but I'm happy to collaborate on a PR with someone else

@Narayanbhat166 Narayanbhat166 added C-feature Category: Feature request or enhancement E-easy Effort: Should be easy to implement and would make a good first PR good first issue Good for newcomers help wanted Extra attention is needed labels May 10, 2023
@MehmetTerc
Copy link

i can take it

@Narayanbhat166
Copy link
Member Author

I have assigned this issue to you. Let me know if you need more clarifications on this.

@MehmetTerc
Copy link

can you describe the issue a little bit clearer

@Narayanbhat166
Copy link
Member Author

Narayanbhat166 commented May 10, 2023

We use this file to store all the developer related configuration like, the database password, log level etc. There is also connector ( you can treat connector as a payment gateway going forward ) configuration present in it. This connector configuration tells about the base url that should be used when calling the connector, List of countries and currencies supported by a connector etc. The connector configuration is developer independent and remains the same whoever uses it. It should not be changed unless you know what you are dealing with.

So it is better to move these connector related configuration to a separate file and make necessary changes to read this file at the start of application.

Few examples of connnector configuration keys are

[connectors.supported]
[connectors]
[connectors.zen]
[bank_config.eps]
[bank_config.ideal]

[pm_filters.stripe]
[pm_filters.worldpay]

[pm_filters.forte]
[connector_customer]
[tokenization]

MehmetTerc pushed a commit to MehmetTerc/hyperswitch that referenced this issue Jun 9, 2023
@subhajit20
Copy link
Contributor

hey @Narayanbhat166 can I take this issue up as there has not been any updates?

@Narayanbhat166
Copy link
Member Author

Hey @subhajit20, Thanks for showing interest. since I have not heard back from the pervious contributor, you can take this up. Feel free to reach out to me if you have any doubts.

@subhajit20
Copy link
Contributor

hey @Narayanbhat166 can you please review my pr once you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement E-easy Effort: Should be easy to implement and would make a good first PR good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

3 participants