Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] remove unnecessary function from Refunds Validate Flow #1521

Closed
2 tasks done
Abhicodes-crypto opened this issue Jun 23, 2023 · 2 comments
Closed
2 tasks done
Assignees
Labels
C-bug Category: Bug good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Abhicodes-crypto
Copy link
Contributor

Abhicodes-crypto commented Jun 23, 2023

Bug Description

Remove this function validate_uniqueness_of_refund_id_against_merchant_id.
Not required as (refund_id, merchant_id ) unique btree, just insert. if insert fails it is not valid .

Expected Behavior

Not required as (refund_id, merchant_id ) unique btree, just insert. if insert fails it is not valid .

Actual Behavior

Does extra DB calls

Steps To Reproduce

Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to reproduce, if relevant.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Context For The Bug

No response

Environment

Are you using hyperswitch hosted version? Yes/No
If yes, please provide the value of the x-request-id response header for helping us debug your issue.

If not (or if building/running locally), please provide the following details:

  1. Operating System or Linux distribution:
  2. Rust version (output of rustc --version): ``
  3. App version (output of cargo r --features vergen -- --version): ``

Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes I am willing to submit a PR!

@Abhicodes-crypto Abhicodes-crypto added C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet labels Jun 23, 2023
@SanchithHegde SanchithHegde removed the S-awaiting-triage Status: New issues that have not been assessed yet label Jun 24, 2023
@Abhicodes-crypto Abhicodes-crypto added the good first issue Good for newcomers label Sep 6, 2023
@Abhicodes-crypto Abhicodes-crypto changed the title [REFACTOR] validate_uniqueness_of_refund_id_against_merchant_id might not be required [REFACTOR] remove unnecessary function from Refunds Validate Flow Sep 6, 2023
@AaronTJDev
Copy link
Contributor

Hi team, can I take this issue?

@Abhicodes-crypto
Copy link
Contributor Author

Hi @AaronTJDev , You can work on this issue. The task is to remove the function validate_uniqueness_of_refund_id_against_merchant_id

You can get more context from here.
#1521 (comment)

Feel free to ask any queries regarding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

No branches or pull requests

3 participants