Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): remove unnecessary function from Refunds Validate Flow #2609

Merged
merged 4 commits into from
Oct 18, 2023
Merged

refactor(router): remove unnecessary function from Refunds Validate Flow #2609

merged 4 commits into from
Oct 18, 2023

Conversation

AaronTJDev
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Refactoring to remove validate_uniqueness_of_refund_id_against_merchant_id as it isn't required because of the db being a unique btree. So you are able to try to insert the refund by id and if the insert fails then the refund is not valid .

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

#1521

How did you test it?

Tested by:

  1. Creating a stripe payment
  2. Creating a refund using the payment id successfully.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AaronTJDev AaronTJDev requested a review from a team as a code owner October 17, 2023 08:36
@SanchithHegde
Copy link
Member

@AaronTJDev Could you address the failing CI checks?

@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-refactor Category: Refactor A-refunds Area: Refund flows hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 17, 2023
@AaronTJDev
Copy link
Contributor Author

@SanchithHegde Apologies, my rust-analyzer plugin didn't catch that error due to some caching issues locally! This is updated now.

SanchithHegde
SanchithHegde approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @AaronTJDev!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 18, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 18, 2023
Merged via the queue into juspay:main with commit 3399328 Oct 18, 2023
10 checks passed
@swangi-kumari
Copy link
Contributor

Hello @AaronTJDev ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@AaronTJDev
Copy link
Contributor Author

Hi @swangi-kumari, thank you for your kindness! However, I've already signed up previously (see link below). Thank you for providing an awesome experience for contributors.

#2456 (comment)

shakeel-3 pushed a commit to shakeel-3/hyperswitch that referenced this pull request Oct 23, 2023
@AaronTJDev @shakeel-3
refactor(router): remove unnecessary function from Refunds Validate F…
a744261 
…low (juspay#2609)

Co-authored-by: Aaron Jackson <aaronjackson@Aarons-MBP.attlocal.net>
shakeel-3 pushed a commit to shakeel-3/hyperswitch that referenced this pull request Oct 23, 2023
@lsampras @shakeel-3
feat(events): add basic event handler to collect application events (j…
1ee054c 
…uspay#2602)

refactor(connector): [multisafepay] Remove Default Case Handling (juspay#2586)

chore(version): v1.59.0

feat(compatibility): added support to connector txn id (juspay#2606)

Co-authored-by: Sahkal Poddar <sahkal.poddar@juspay.in>

refactor(connector): [Nuvei] remove default case handling (juspay#2584)

Co-authored-by: Prasunna Soppa <70575890+prasunna09@users.noreply.github.com>

feat(router): Better UI payment link and order details product image and merchant config support (juspay#2583)

Co-authored-by: Sahkal Poddar <sahkal.poddar@juspay.in>
Co-authored-by: Kashif <46213975+kashif-m@users.noreply.github.com>
Co-authored-by: Kashif <mohammed.kashif@juspay.in>
Co-authored-by: Bernard Eugine <114725419+bernard-eugine@users.noreply.github.com>
Co-authored-by: Kashif <kashif@protonmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

refactor(router): throw bad request error on applepay verification failure (juspay#2607)

fix: make push to drainer generic and add application metrics for KV (juspay#2563)

feat: add updated_by to tracker tables (juspay#2604)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

chore(version): v1.60.0

fix(connector): [Authorizedotnet]fix error deserialization incase of authentication failure (juspay#2600)

Signed-off-by: chikke srujan <121822803+srujanchikke@users.noreply.github.com>

docs(postman): Rewrite postman documentation to help devs develop tests for their features (juspay#2613)

fix(payments): fix payment update enum being inserted into kv (juspay#2612)

Co-authored-by: Kartikeya Hegde <karthikey.hegde@juspay.in>

feat(connector): [Aci] Update connector_response_reference_id with merchant reference (juspay#2551)

chore(scripts): add connector script changes (juspay#2620)

feat(merchant_account): add merchant account list endpoint  (juspay#2560)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix(connector): [Paypal]fix error deserelization for source verification call (juspay#2611)

feat(events): add events for incoming API requests (juspay#2621)

Co-authored-by: Nishant Joshi <nishant.joshi@juspay.in>

feat: update surcharge_amount and tax_amount in update_trackers of payment_confirm (juspay#2603)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

refactor(router): remove unnecessary function from Refunds Validate Flow (juspay#2609)

Co-authored-by: Aaron Jackson <aaronjackson@Aarons-MBP.attlocal.net>

feat(connector): [Bambora] use connector_request_reference_id (juspay#2518)

refactor: refactor connector auth type failure to 4xx (juspay#2616)

feat(Connector): [Paypal] add support for dispute webhooks for paypal connector (juspay#2353)

refactor(events): Allow box dyn for event handler (juspay#2629)

Co-authored-by: Nishant Joshi <nishant.joshi@juspay.in>

feat(apple_pay): add support for decrypted apple pay token for checkout (juspay#2628)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Prajjwal Kumar <prajjwal.kumar@juspay.in>

refactor(payment_connector): allow connector label to be updated (juspay#2622)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat(core): replace temp locker with redis (juspay#2594)

feat(connector): [Tsys] Use connector_request_reference_id as reference to the connector (juspay#2631)

test(postman): update postman collection files

chore(version): v1.61.0

ci: update codeowners (juspay#2632)

Co-authored-by: Sanchith Hegde <22217505+SanchithHegde@users.noreply.github.com>

ci: add ci workflow for validating hotfix pr (juspay#2597)

ci(postman): Add Customer list endpoint (juspay#2623)

chore(deps): bump rustix from 0.37.24 to 0.37.25 (juspay#2637)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat(connector): [Worldpay] Use connector_request_reference_id as reference to the connector (juspay#2553)

Co-authored-by: Prasunna Soppa <70575890+prasunna09@users.noreply.github.com>
Co-authored-by: chikke srujan <121822803+srujanchikke@users.noreply.github.com>

refactor(connector): [Dlocal] Currency Unit Conversion (juspay#2615)

Co-authored-by: chikke srujan <121822803+srujanchikke@users.noreply.github.com>

refactor(connector): [Iatapay] remove default case handling (juspay#2587)

Co-authored-by: Prasunna Soppa <70575890+prasunna09@users.noreply.github.com>

feat(connector): [ProphetPay] Template generation (juspay#2610)

Co-authored-by: Arjun Karthik <m.arjunkarthik@gmail.com>

build(deps): use `async-bb8-diesel` from `crates.io` instead of git repository (juspay#2619)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

refactor: remove code related to temp locker (juspay#2640)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: payment_method_data and description null during payment confirm (juspay#2618)

Co-authored-by: Abhishek Marrivagu <68317979+Abhicodes-crypto@users.noreply.github.com>

refactor(connector): [noon] remove cancellation_reason (juspay#2627)

refactor: add surcharge_applicable to payment_intent and remove surcharge_metadata from payment_attempt (juspay#2642)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

refactor(connector): [Forte] Remove Default Case Handling (juspay#2625)

feat(connector): [Bambora] Use connector_response_reference_id as reference to the connector (juspay#2635)

feat(connector): [Klarna] Add order id as the reference id to merchant (juspay#2614)

refactor(connector): [Dlocal] remove default case handling (juspay#2624)

test(postman): update postman collection files

chore(version): v1.62.0

refactor(router): [Nexi nets] Remove Default Case Handling (juspay#2639)

feat: add support for updating surcharge_applicable field intent (juspay#2647)

fix: kms decryption of redis_temp_locker_encryption_key (juspay#2650)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

chore(version): v1.63.0

feat(events): Add request body to api events logger (juspay#2660)

refactor(connector): Use connector_response_reference_id  for Shift4 (juspay#2492)

Co-authored-by: Dmytro Danylov <icdmytro.danylov@americanwell.com>

fix(router): disable openapi examples (juspay#2648)

refactor(connector): [PowerTranz] refactor powertranz payments to remove default cases (juspay#2547)

chore(version): v1.64.0

refactor: revert redis temp locker logic (juspay#2670)

Generate and validate OpenAPI spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

Assignees

@AaronTJDev AaronTJDev

Labels
A-refunds Area: Refund flows C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AaronTJDev @SanchithHegde @swangi-kumari @Abhicodes-crypto