Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [NMI] Use connector_response_reference_id as reference to merchant #2338

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 14 comments · Fixed by #2702
Closed
2 tasks done

[FEATURE]: [NMI] Use connector_response_reference_id as reference to merchant #2338

Sakilmostak opened this issue Sep 22, 2023 · 14 comments · Fixed by #2702
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [NMI] Use connector_response_reference_id as reference to merchant [FEATURE]: [NMI] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@TechWizard9999
Copy link

😊 "I'd be delighted to work on this issue! Could you please assign it to me?"

@AkshayaFoiger
Copy link
Contributor

Hey @TechWizard9999 , I see that you're already assigned to #2352. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2352 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@parasss19
Copy link

Hey @AkshayaFoiger I want to work on this issue could you please assign this issue

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 1, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @parasss19, sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@parasss19
Copy link

Hey @AkshayaFoiger is there any docs for NMI?

@AkshayaFoiger
Copy link
Contributor

Hello @parasss19 , I kindly suggest that you consult NMI's API documentation for reference and guidance.

In case you have any further queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@VedantKhairnar
Copy link
Collaborator

Hey @parasss19 ,
Let us know if you face any issues. Happy to help! : )

@parasss19
Copy link

Hey @parasss19 , Let us know if you face any issues. Happy to help! : )

Yeah actually I am busy with some work I will send PR today

@VedantKhairnar
Copy link
Collaborator

Sure @parasss19
Let us know if you face any issues.

@VedantKhairnar
Copy link
Collaborator

Hey @parasss19 ,
Please let me know if you are working on it.
Thanks.

@deepanshu-iiitu
Copy link
Contributor

Hello @parasss19 , we didn't hear back from you, so we are unassigning you from this issue. If you are interested, we will assign you with other issues, if the current one is taken.

@deepanshu-iiitu deepanshu-iiitu added the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 25, 2023
@Hangsaai
Copy link
Contributor

Hey @deepanshu-iiitu , can you assign this to me

@TejasMate
Copy link
Contributor

@AkshayaFoiger @deepanshu-iiitu @VedantKhairnar @Sakilmostak
Could you please assign this issue to me? This will be my first contribution to this repo.

@deepanshu-iiitu
Copy link
Contributor

Hey @TejasMate , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@deepanshu-iiitu deepanshu-iiitu removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
8 participants