Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Worldpay] Use connector_response_reference_id as reference to merchant #2352

Open
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 13 comments
Open
2 tasks done
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants Rust Pull requests that update Rust code

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Worldpay] Use connector_response_reference_id as reference to merchant [FEATURE]: [Worldpay] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added good first issue Good for newcomers Rust Pull requests that update Rust code labels Sep 28, 2023
@TechWizard9999
Copy link

😊 "I'd be delighted to work on this issue! Could you please assign it to me?"

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 1, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @TechWizard9999 , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@imSanko
Copy link

imSanko commented Oct 5, 2023

@AkshayaFoiger I just want to work on this issue! Is it going to be alright if I send a PR or after you assign that to me?

@AkshayaFoiger
Copy link
Contributor

Hello @imSanko,

This issue has already been assigned to @TechWizard9999. However, we have encountered similar issues with different connectors. I would suggest considering an attempt to address one of those.

@himanshuParashar0101
Copy link

i want to work on this issue could you please assign me to this issue

@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Oct 5, 2023

i want to work on this issue could you please assign me to this issue

Hi @himanshuParashar0101,

This issue has already been assigned to @TechWizard9999. However, we have encountered similar issues with different connectors. I would suggest considering an attempt to address one of these issues.

@VedantKhairnar
Copy link
Contributor

Hey @TechWizard9999 ,
Let us know if you face any issues. Happy to help! : )

@VedantKhairnar
Copy link
Contributor

Hey @TechWizard9999 ,
Just checking in - are you working on it or shall we consider reassigning it to someone else?

@speedhs
Copy link

speedhs commented Oct 15, 2023

Can I work on this one if @TechWizard9999 is not currently work on this?

@VedantKhairnar
Copy link
Contributor

Hey @speedhs , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with.

@speedhs
Copy link

speedhs commented Oct 25, 2023

Hey! i went throught the file. I wanted to ask on thing. In the files attached for reference the customer response field is stored in a different way than that for worldpay. Can you clarify on the fields used in response.rs for worldpay?

@Sakilmostak
Copy link
Contributor Author

Hello @speedhs, can be more specific about the "files attached for reference", might be able to help you out better. Anyways, if you are talking about how we are handling the response i.e. the try_from implementation for the response. To simplify it, We take the response from the connector, parsing it, and then convert it into suitable struct for our core to handle the response. You need to look into what parameters are present while parsing(related struct in response.rs) and which one of those can be used as connector_response_reference_id. (In case such parameter is not present, create on the basis of docs) Hope this helps

@swangi-kumari
Copy link
Contributor

Hey @speedhs ,
Are you still working on this issue?
Please let us know if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants