test(selenium): read config from CONNECTOR_AUTH_FILE_PATH environment variable and fix bugs in UI tests
#1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing with the remote repository
Pulled from main
ArjunKarthik
previously approved these changes
May 22, 2023
Comment on lines
42
to
53
| pub hs_base_url: Option<String>, | ||
| pub hs_api_key: Option<String>, | ||
| pub hs_test_browser: Option<String>, | ||
| pub chrome_profile_path: Option<String>, | ||
| pub firefox_profile_path: Option<String>, | ||
| pub pypl_email: Option<String>, | ||
| pub pypl_pass: Option<String>, | ||
| pub gmail_email: Option<String>, | ||
| pub gmail_pass: Option<String>, | ||
| pub configs_url: Option<String>, | ||
| pub stripe_pub_key: Option<String>, | ||
| pub testcases_path: Option<String>, |
There was a problem hiding this comment.
I'd prefer moving all these to a struct instead, since it's quite easy to make mistakes when writing the TOML files for the current configuration structure.
SanchithHegde
added
the
S-waiting-on-author
SanchithHegde
changed the title
CONNECTOR_AUTH_FILE_PATH environment variable and fix bugs in UI tests
jarnura
requested changes
May 22, 2023
| @@ -489,5 +550,5 @@ pub fn handle_test_error( | |||
| } | |||
|
|
|||
| pub fn get_env(name: &str) -> String { | |||
| env::var(name).unwrap_or_else(|_| panic!("{name} not present")) //Issue: #924 | |||
| env::var(name).unwrap_or_else(|_| panic!("{name} not present")) | |||
There was a problem hiding this comment.
Configs from auth.toml takes priority over env variables, if you want to override configs you can use this, this is the not the primary setting
SanchithHegde
added
the
S-needs-conflict-resolution
15 tasks
jagan-jaya
removed
the
S-needs-conflict-resolution
jagan-jaya
added
S-waiting-on-review
jarnura
approved these changes
May 31, 2023
SanchithHegde
approved these changes
May 31, 2023
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Closes #924
Additional Changes
Motivation and Context
To support automatic api_key generation by accepting the configs from sample_auth file
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy