-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(selenium): read config from CONNECTOR_AUTH_FILE_PATH
environment variable and fix bugs in UI tests
#1225
Conversation
Syncing with the remote repository
Pulled from main
pub hs_base_url: Option<String>, | ||
pub hs_api_key: Option<String>, | ||
pub hs_test_browser: Option<String>, | ||
pub chrome_profile_path: Option<String>, | ||
pub firefox_profile_path: Option<String>, | ||
pub pypl_email: Option<String>, | ||
pub pypl_pass: Option<String>, | ||
pub gmail_email: Option<String>, | ||
pub gmail_pass: Option<String>, | ||
pub configs_url: Option<String>, | ||
pub stripe_pub_key: Option<String>, | ||
pub testcases_path: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer moving all these to a struct instead, since it's quite easy to make mistakes when writing the TOML files for the current configuration structure.
CONNECTOR_AUTH_FILE_PATH
environment variable and fix bugs in UI tests
@@ -489,5 +550,5 @@ pub fn handle_test_error( | |||
} | |||
|
|||
pub fn get_env(name: &str) -> String { | |||
env::var(name).unwrap_or_else(|_| panic!("{name} not present")) //Issue: #924 | |||
env::var(name).unwrap_or_else(|_| panic!("{name} not present")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Issue id back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configs from auth.toml takes priority over env variables, if you want to override configs you can use this, this is the not the primary setting
Type of Change
Description
Closes #924
Additional Changes
Motivation and Context
To support automatic api_key generation by accepting the configs from sample_auth file
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy