Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector): [Adyen] Add test for bank debits, bank redirects, and wallets #1260

Merged
merged 13 commits into from
Jun 28, 2023
Merged

test(connector): [Adyen] Add test for bank debits, bank redirects, and wallets #1260

merged 13 commits into from
Jun 28, 2023

Conversation

swangi-kumari
Copy link
Contributor

@swangi-kumari swangi-kumari commented May 24, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-05-24 at 6 30 02 PM Screenshot 2023-05-24 at 4 45 20 PM Screenshot 2023-05-25 at 4 18 22 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 24, 2023
@swangi-kumari swangi-kumari self-assigned this May 24, 2023
@swangi-kumari swangi-kumari requested review from a team as code owners May 24, 2023 16:36
SanchithHegde
SanchithHegde reviewed May 24, 2023
View reviewed changes
crates/router/tests/connectors/adyen_ui.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/adyen_ui.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/connector_auth.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/adyen_ui.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/adyen_ui.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/adyen_ui.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-blocked Status: Blocked on something else or other implementation work S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 24, 2023
@SanchithHegde
Copy link
Member

Blocked on #1225.

@swangi-kumari swangi-kumari changed the title test(connector): [Adyen] Add test for paypal, bank debits and bank redirects test(connector): [Adyen] Add test for paypal, bank debits, bank redirects, and wallets May 25, 2023
@swangi-kumari swangi-kumari changed the title test(connector): [Adyen] Add test for paypal, bank debits, bank redirects, and wallets test(connector): [Adyen] Add test for bank debits, bank redirects, and wallets May 25, 2023
@ArjunKarthik ArjunKarthik added the low-risk label to track PRs which might have less impact on hyperswitch after merge label Jun 28, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit eddcc34 Jun 28, 2023
6 checks passed
@SanchithHegde SanchithHegde deleted the adyen_ui_test branch June 28, 2023 13:58
@SanchithHegde SanchithHegde removed S-blocked Status: Blocked on something else or other implementation work S-waiting-on-author Status: This PR is incomplete or needs to address review comments low-risk label to track PRs which might have less impact on hyperswitch after merge labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jagan-jaya jagan-jaya Awaiting requested review from jagan-jaya

Assignees

@swangi-kumari swangi-kumari

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@swangi-kumari @SanchithHegde @ArjunKarthik @jagan-jaya