Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): expand webhook event coverage stripe nmi #3298

Merged
merged 4 commits into from
Jan 9, 2024
Merged

feat(connector): expand webhook event coverage stripe nmi #3298

merged 4 commits into from
Jan 9, 2024

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Jan 9, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add support for PaymentIntentAuthorizationSuccess incoming webhook event for stripe

Add following incoming webhook support for NMI:

PaymentIntentAuthorizationSuccess,
PaymentIntentCaptureSuccess,
PaymentIntentAuthorizationFailure,
PaymentIntentCaptureFailure,
PaymentIntentCancelFailure,

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Uploading Screenshot 2024-01-09 at 7.21.42 PM.png…

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Jan 9, 2024
@hrithikesh026 hrithikesh026 self-assigned this Jan 9, 2024
@hrithikesh026 hrithikesh026 requested review from a team as code owners January 9, 2024 14:39
@hrithikesh026 hrithikesh026 mentioned this pull request Jan 9, 2024
Merged
15 tasks
@hrithikesh026 hrithikesh026 changed the base branch from main to add-new-incoming-webhook-events January 9, 2024 14:44
@hrithikesh026 hrithikesh026 merged commit 7457f74 into add-new-incoming-webhook-events Jan 9, 2024
5 of 11 checks passed
@hrithikesh026 hrithikesh026 deleted the expand-webhook-event-coverage-stripe-nmi branch January 9, 2024 14:52
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

@jarnura jarnura Awaiting requested review from jarnura

Assignees

@hrithikesh026 hrithikesh026

Labels
C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrithikesh026 @SanchithHegde @hrithikeshvm