Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Noon] add new field max_amount to mandate request #3589

Closed

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Resolves #3445

Note
1.While connector create ensure test_mode is set to true
2.Ensure the currency passed is AED and country is AE

How did you test it?

1.Create a CIT with noon
with

  "connector_metadata": {
        "noon": {
            "order_category": "pay"
        }
    }
Screenshot 2024-01-12 at 2 16 26 PM without order_category it should throw an error Screenshot 2024-01-12 at 2 16 44 PM
  1. Make a MIT
Screenshot 2024-01-12 at 2 02 35 PM

3.Test through stripe compatibility layer
CIT
Screenshot 2024-02-06 at 7 11 36 PM

MIT
Screenshot 2024-02-06 at 7 11 30 PM

MIT with greater amount
Screenshot 2024-02-06 at 7 11 19 PM

4.Test Applepay mandates

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger requested review from a team as code owners February 8, 2024 07:35
@AkshayaFoiger AkshayaFoiger changed the base branch from main to hotfix-2024.02.02.0 February 8, 2024 07:37
@AkshayaFoiger AkshayaFoiger deleted the fix/noon-mandate-max-amount branch February 8, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] : Noon Api Contract Changes
1 participant