refactor(payment_methods): add BankRedirect payment method data to new domain type to be used in connector module #4175
+896
−807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent_method_data-to-be-used-in-connector-module
swangi-kumari
added
A-connector-integration
| @@ -874,218 +874,220 @@ pub enum OnlineBankingSlovakiaBanks { | |||
| Viamo, | |||
| } | |||
|
|
|||
| impl TryFrom<&api_enums::BankNames> for OnlineBankingSlovakiaBanks { | |||
| impl TryFrom<&common_enums::enums::BankNames> for OnlineBankingSlovakiaBanks { | |||
There was a problem hiding this comment.
why do we have common_enums::enums can't we directly use common_enums since there are re exports?
Comment on lines
435
to
438
| billing_details: billing_details.map(|billing| BankRedirectBilling { | ||
| billing_name: billing.billing_name, | ||
| email: billing.email, | ||
| }), |
There was a problem hiding this comment.
You can have a From impl for this since this is reused many times
Comment on lines
647
to
654
| fn map_billing_details( | ||
| billing_details: Option<api_models::payments::BankRedirectBilling>, | ||
| ) -> Option<BankRedirectBilling> { | ||
| billing_details.map(|billing| BankRedirectBilling { | ||
| billing_name: billing.billing_name, | ||
| email: billing.email, | ||
| }) | ||
| } |
There was a problem hiding this comment.
This could have been a From impl
Narayanbhat166
previously approved these changes
Apr 8, 2024
Narayanbhat166
approved these changes
Apr 8, 2024
ArjunKarthik
approved these changes
Apr 8, 2024
kashif-m
pushed a commit
that referenced
this pull request
Apr 10, 2024
…w domain type to be used in connector module (#4175) Co-authored-by: Narayan Bhat <narayan.bhat@juspay.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
We need to have separate types for api model and domain, currently we are using the api type in application as well.
This PR add a new domain type for BankRedirect payment_method_data to be used everywhere in the application.
Additional Changes
Motivation and Context
How did you test it?
Impact
Checklist
cargo +nightly fmt --allcargo clippy