Replies: 1 comment 1 reply
-
Thanks for submitting a discussion post @devshjeon! I'm now trying to recall the official motivation behind merging in the original change in (other than the brief feature request outlined in #1355). In retrospect, I'm feeling like we should have put #1356 behind a (the vast majority of pages simply keep the link to the current page - Wikipedia is my go-to example) Things are a bit harder since we just cut a release with this feature, so switching it back would be strange. @pdmosses do you have any thoughts on this? |
Beta Was this translation helpful? Give feedback.
-
I'm really enjoying this template. thank you
Recently, when I ran Chrome's lighthouse, I found an issue in the SEO section and checked the code.
I confirmed that the problem occurred while removing the href attribute of the scrollNav function in the just-the-docs.js file.
And the reason why the href attribute should be deleted was also confirmed through the commit. #1356 (comment)
I ask that you also consider this option to prevent this event.
https://stackoverflow.com/questions/13955667/disabled-href-tag/27057625#27057625
This option is supported by most browsers, so it seems there will be no problems when applying it.
https://developer.mozilla.org/en-US/docs/Web/CSS/pointer-events#browser_compatibility
Please let me know as I may be wrong in what I said.
thank you
Beta Was this translation helpful? Give feedback.
All reactions